-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add eyedropper tool functionality to browser view #27275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaurencin
force-pushed
the
eyedropper-fix
branch
from
January 16, 2021 02:05
e71475a
to
d7bdbed
Compare
mlaurencin
changed the title
[WIP] fix: add eyedropper tool functionality to browser view
fix: add eyedropper tool functionality to browser view
Jan 20, 2021
mlaurencin
force-pushed
the
eyedropper-fix
branch
from
January 20, 2021 23:57
663e8ef
to
0f74d58
Compare
zcbenz
approved these changes
Jan 21, 2021
jkleinsc
approved these changes
Jan 21, 2021
codebytere
approved these changes
Jan 21, 2021
Release Notes Persisted
|
I was unable to backport this PR to "11-x-y" cleanly; |
I have automatically backported this PR to "12-x-y", please check out #27442 |
zcbenz
pushed a commit
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #26883
This PR adds the functionality of the Chromium eyedropper when using the color picker tool. Previously when you clicked on the eyedropper from the color picker nothing would happen. The eyedropper now works as expected, as colors in the window can be selected.
There is a known issue (reported here) in Chromium where, in a multiple monitor setup, the tool may function incorrectly if the main monitor is not positioned in the upper left corner.
Fiddle: https://gist.github.com/mlaurencin/cb0f0b2d6b075e67721c41474c0f17da
Examples:
(Be aware that the color palette is not rendered in the screen capture, but was displayed like in the above image)
smaller.eyedropper.mp4
Checklist
npm test
passesRelease Notes
Notes: None